New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): inline non-buildable libs for tsc and swc #12280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
September 28, 2022 11:15
1b623c1
to
7fe2575
Compare
jaysoo
reviewed
Sep 29, 2022
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
September 29, 2022 12:35
7fe2575
to
9167cc2
Compare
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
October 3, 2022 14:31
9167cc2
to
284d2c1
Compare
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
October 4, 2022 03:42
284d2c1
to
3027fd2
Compare
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
October 4, 2022 15:22
3027fd2
to
c81ce72
Compare
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
October 5, 2022 04:14
c81ce72
to
8a37f6a
Compare
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
October 6, 2022 04:19
8a37f6a
to
5ead9bc
Compare
nartc
force-pushed
the
feat/inline-non-buildable-lib-swc
branch
from
October 6, 2022 16:33
5ead9bc
to
58d6a6d
Compare
jaysoo
approved these changes
Oct 6, 2022
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nrwl/js:tsc
andnrwl/js:swc
do not work with non-buildable librariesExpected Behavior
nrwl/js:tsc
andnrwl/js:swc
works with non-buildable libraries by inlining them.chore(js): inline non-buildablie libs
Related Issue(s)
Fixes #