Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): cypress vite #13474

Merged
merged 1 commit into from
Dec 15, 2022
Merged

feat(testing): cypress vite #13474

merged 1 commit into from
Dec 15, 2022

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Nov 29, 2022

Transform and run Cypress e2e specs using vite.

It works as is, but needs some adjustments to the vite preprocessor.

To do:

  • Add tests for cypress-project generator
  • Adjust vite-preprocessor to our needs (no more - no less)
  • Review with Caleb
  • Fix failing tests
  • Add Component Testing settings
  • Add extensive docs

@nx-cloud-staging
Copy link

nx-cloud-staging bot commented Nov 29, 2022

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 4:05AM (UTC)

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some guidance off what we talked about earlier. mainly without needing component testing support it should be greatly simplify what needs to happen for e2e.

@mandarini
Copy link
Member Author

Copied over https://github.com/mammadataei/cypress-vite for now as is, will adjust it to our needs. Let's see if it works for now.

@mandarini
Copy link
Member Author

@barbados-clemens works like a charm, but I copied the cypress-vite plugin as is!

@nx-cloud
Copy link

nx-cloud bot commented Dec 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 07da54c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx depcheck --no-dte
nx depcheck --no-dte
nx depcheck --no-dte
✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants