feat(graph): use daemon file watcher instead of chokidar #13564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Phillip9587
commented
Dec 2, 2022
Phillip9587
force-pushed
the
daemon-watcher-for-graph
branch
from
3f2929b
to
ce4fc96
Compare
Phillip9587
force-pushed
the
daemon-watcher-for-graph
branch
from
ce4fc96
to
b2a30c4
Compare
|
@Cammisuli Is there anything I can do to get this merged? |
|
Not at the moment. I haven't taken a thorough look yet, so I don't have many updates for you :( I have a feeling that things will be good, but I just want to double check things on my side :) |
Phillip9587
force-pushed
the
daemon-watcher-for-graph
branch
from
b2a30c4
to
74862c2
Compare
Phillip9587
force-pushed
the
daemon-watcher-for-graph
branch
from
74862c2
to
9025ed0
Compare
|
@Cammisuli Thanks a lot for merging this. Do you think it is possible to convert the remaining usages of |
|
Yea, it should be possible. You're more than welcomed to refactor those usages if you like 🙂 |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx depends on
chokidarto watch for file changes in the workspaceLayout directories.Problems:
Expected Behavior
nx should not depend on
chokidarand should use the daemon file watcher which internally uses@parcel/watcher.Related Issue(s)
Fixes #