Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): add dts to build options #13934

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Dec 20, 2022

Add dts to the plugins array in vite.config.ts, when converting non-buildable lib to buildable.

  • check why snapshot does not have vitest types
  • check the issue with the conditional config - it should ignore it for plugins

@mandarini mandarini self-assigned this Dec 20, 2022
@vercel
Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 22, 2022 at 10:05AM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 125ae37. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 20 targets

Sent with 💌 from NxCloud.

@mandarini mandarini force-pushed the fix/add-dts-vite-conv branch 7 times, most recently from efe546e to 2fb4953 Compare December 20, 2022 18:17
@mandarini mandarini marked this pull request as ready for review December 21, 2022 09:27
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants