Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add backwards compatibility to webpack-browser #14159

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 5, 2023

Current Behavior

@nrwl/angular:webpack-browser on Nx 15+ does not work for Angular 14 applications.

Expected Behavior

We should ensure backwards compatibility by using the angular-devkit that is installed in the users' workspaces.

This has been tested with Angular 14 and Angular 15.

Tested:

  • General Building
  • Buildable Libs
  • Custom Webpack Config

Note: To test in Angular 14, you'll need to delete the @angular-devkit folder from node_modules/@nrwl/angular/node_modules to allow the executor to find the repo's top-level angular-devkit.

This will be resolved when backwards compat support is complete and we move @nrwl/angular to use peerDependencies rather than direct dependency.

@Coly010 Coly010 self-assigned this Jan 5, 2023
@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 5, 2023 at 0:19AM (UTC)

@Coly010 Coly010 merged commit 2beebf4 into nrwl:master Jan 5, 2023
@Coly010 Coly010 deleted the angular/bck-sprt-webpack-browser branch January 5, 2023 13:01
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants