Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): add vite-tsconfig-paths to storybook #14161

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

mandarini
Copy link
Member

Add the required vite config on the Storybook configuration, for correct path resolution.

See this repo for reference: https://github.com/mandarini/imported-libs

@mandarini mandarini self-assigned this Jan 5, 2023
@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 5, 2023 at 1:04PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There seems to be a lot of whitespace generated in the snapshots, it shouldn't make any real difference, just something i noticed.

@mandarini
Copy link
Member Author

The whitespace gets cleared with the formatFiles function, in the actual generated result! :D

@mandarini mandarini force-pushed the fix/storybook-vite-tsconfig-paths branch from 0497dbc to a2af57b Compare January 5, 2023 13:04
@mandarini mandarini merged commit 8d329e0 into nrwl:master Jan 5, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants