Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): update esbuild executor to emit correct events #14193

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 6, 2023

The esbuild executor is not emitting the correct outfile when watching, and when not watching it does not emit events.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 6, 2023 at 5:00PM (UTC)

@jaysoo jaysoo marked this pull request as ready for review January 6, 2023 16:42
@jaysoo jaysoo merged commit d0d6e85 into nrwl:master Jan 6, 2023
@jaysoo jaysoo deleted the fix/esbuild-build-events branch January 6, 2023 17:12
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants