fix(misc): loosen chalk version #14276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Phillip9587
force-pushed
the
chalk-4-1
branch
from
d0d9797
to
73e2870
Compare
FrozenPandaz
force-pushed
the
chalk-4-1
branch
from
73e2870
to
89dbf4f
Compare
FrozenPandaz
approved these changes
Jan 13, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 17, 2023
(cherry picked from commit 415d1c7)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
chalkversion is locked to 4.1.0Expected Behavior
chalkversion is ^4.1.0 to support minor and patch level releases of chalk.I also removed
chalkfrom the dependencies of packages not using it.Note: I know that the releases 4.1.1 and 4.1.2 of chalk only contained readme updates, but most packages updated to 4.1.2 or use the ^4.1.0 semver range while Nx locks the version to 4.1.0. This leads to npm not hoisting the package.