Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): make the JSON parser accepts trailing commas by default #14317

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 12, 2023

This PR makes the JSON parser allow trailing commas by default.

I have had generators failed because of trailing commas in tsconfig.json files - see #14167 (comment) for details.

It is kind of a pain because typescript is happy with trailing commas but still Nx would complain.

With this change trailing commas would be allowed by default making the parser more lenient.

Fixes #14203

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 5:42PM (UTC)

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 0d4833c into nrwl:master Jan 12, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JSON]: make parsing lenient by default and display better errors
2 participants