Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): a couple of minor fix #14318

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix(vite): a couple of minor fix #14318

merged 1 commit into from
Jan 12, 2023

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 12, 2023

  • close the dev server before process exists,
  • use server.resolvedUrls for the base url.

Note that server.resolvedUrls is what is used by server.printUrls(); that the executor calls on l.71

/cc @mandarini

- close the dev server before process exists,
- use server.resolvedUrls for the base url.
@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 12, 2023 at 5:48PM (UTC)

@mandarini mandarini self-requested a review January 12, 2023 18:01
@mandarini mandarini enabled auto-merge (squash) January 12, 2023 18:01
@mandarini
Copy link
Member

@vicb thanks for all your work on @nrwl/vite. Do you mind joining the nx-community slack and pinging me there? I'd like to chat about your experience with @nrwl/vite and how you use it, it could be helpful!

If you don't want, that's ok! :)

@mandarini mandarini merged commit fd1c704 into nrwl:master Jan 12, 2023
@vicb vicb deleted the vite/2fix branch January 12, 2023 18:19
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants