fix(webpack): fix loader config for global styles #14323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
commented
Jan 12, 2023
| @@ -432,6 +475,26 @@ function getCommonLoadersForGlobalCss( | |||
| ]; | |||
| } | |||
|
|
|||
| function getCommonLoadersForGlobalStyle( | |||
There was a problem hiding this comment.
Keep this separate from getCommonLoadersForGlobalCss, because there are minor differences and we want to avoid bad abstractions like we did previously.
jaysoo
commented
Jan 12, 2023
| @@ -214,35 +214,78 @@ export function withWeb() { | |||
| }, | |||
| ]; | |||
|
|
|||
| const rules: RuleSetRule[] = [ | |||
| const globalStyleRules: RuleSetRule[] = [ | |||
There was a problem hiding this comment.
Expand global stylesheets to process less, stylus as well. It was missed previously.
FrozenPandaz
approved these changes
Jan 12, 2023
jaysoo
force-pushed
the
fix/webpack-global-styles
branch
from
3333bf0
to
681cd79
Compare
jaysoo
force-pushed
the
fix/webpack-global-styles
branch
2 times, most recently
from
6497be2
to
d1af744
Compare
jaysoo
force-pushed
the
fix/webpack-global-styles
branch
from
d1af744
to
7d2a074
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with global stylesheets specified via
stylesoption in@nrwl/webpack:webpackexecutor.Now that
raw-css-loaderis removed (replaced bycss-loader) there are some options we need to set to make it work.Current Behavior
Using
url(...)in stylesheets, such asbackground-image: url(/'assets/bg.png')results in an error sincecss-loaderis resolving the URL.Expected Behavior
Using
url(...)should work.Related Issue(s)
Fixes #