Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): adding support for async plugins in compose-plugins utility #14447

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

Ktoxcon
Copy link
Contributor

@Ktoxcon Ktoxcon commented Jan 18, 2023

closes #14344

Current Behavior

  • Currently the withModuleFederation utility returns a promise when called, and the composePlugins utility expects a list of NxWebpackPlugins elements.
  • File generation templates for module federation in react added an extra ')' character to the generated files.

Expected Behavior

  • The composePlugin utility should be able to accept a list of elements of type NxWebpackPlugin or have the ability to resolve the plugin from a promise.
  • File generation templates should not generate malformed files.

Related Issue(s)

Fixes #14344

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 21, 2023 at 1:56AM (UTC)

@jaysoo jaysoo enabled auto-merge (squash) January 21, 2023 01:55
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong webpack config for react app with module federation
2 participants