feat(node): add docker as a build target

[ndcunningham]

This adds a docker configuration to a current node project (standalone / integrated)

It should create a Dockerfile which builds an image based off the output path for your node project
Running the command

npx nx g @nrwl/node:app --framework=fastify api --docker

Should create a folder structure similar to

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 20, 2023 at 10:06PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7978d81. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=f1f69df47018aedb332907744477f22defb1bc11 --head=7978d815c29b0cc7fdf99a5342a70534b299365a --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=f1f69df47018aedb332907744477f22defb1bc11 --head=7978d815c29b0cc7fdf99a5342a70534b299365a --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck documentation --parallel=1 --no-dte
• nx affected --target=build --base=f1f69df47018aedb332907744477f22defb1bc11 --head=7978d815c29b0cc7fdf99a5342a70534b299365a --parallel=3
• nx affected --target=lint --base=f1f69df47018aedb332907744477f22defb1bc11 --head=7978d815c29b0cc7fdf99a5342a70534b299365a --parallel=3
• nx-cloud record -- nx format:check --base=f1f69df47018aedb332907744477f22defb1bc11 --head=7978d815c29b0cc7fdf99a5342a70534b299365a
• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox

---

Sent with 💌 from NxCloud.

[vicb]

You probably want something more elaborate in the lines of

ROM docker.io/node:lts-alpine

ENV NODE_ENV production

WORKDIR <%= app %>
RUN npm install -g npm@latest

COPY <%= buildLocation %> ./
RUN npm install --omit=dev

RUN chown -R node:node .
USER node

CMD [ "node", "<%= main %>" ]

[jaysoo]

FROM docker.io/node:lts-alpine makse sense, I wouldn't do npm install in Dockerfile since the dist should already be present andd bundled.

If users have external dependencies (e.g. not bundled in) then it makes sense to include install step -- I think they can add the install it manually for now.

[jaysoo]

Also for can run COPY --chown node:node <%= buildLocation %> .

Like:

RUN addgroup --system node && \
          adduser --system -G node node

COPY --chown node:node <%= buildLocation %> .

[vicb]

I wouldn't do npm install in Dockerfile since the dist should already be present and bundled.

In my setup (node app / webpack) the deps are not bundled.
I was not aware of the possibility that deps could be bundled for a node app.

[jaysoo]

Yeah, it's possible if you use esbuild or webpack... not plain tsc though. I highly recommend it since you benefit from a smaller image size as well. :)

[vicb]

I wouldn't though tsc does bundling or tree shaking!

[jaysoo]

FROM docker.io/node:lts-alpine makse sense, I wouldn't do npm install in Dockerfile since the dist should already be present andd bundled.

If users have external dependencies (e.g. not bundled in) then it makes sense to include install step -- I think they can add the install it manually for now.

[jaysoo]

Also for can run COPY --chown node:node <%= buildLocation %> .

Like:

RUN addgroup --system node && \
          adduser --system -G node node

COPY --chown node:node <%= buildLocation %> .

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.