Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): handle new https options in webpack-dev-server #14520

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 20, 2023

Support new https option in webpack-dev-server when logging out started at https://localhost:<port> message.

Current Behavior

Nx logs out the wrong URL.

Expected Behavior

Nx logs out correct URL.

Related Issue(s)

Fixes #14424

@vercel
Copy link

vercel bot commented Jan 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 20, 2023 at 7:21PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 42a92da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=e2e --base=4c2364864a8a1e0f66d95bb7e338f381075d9ce0 --head=a2af8658ae327f15efa41a1a3afcc53b7b12456f --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
✅ Successfully ran 20 targets

Sent with 💌 from NxCloud.

@jaysoo jaysoo enabled auto-merge (squash) January 20, 2023 19:24
@jaysoo jaysoo merged commit da0e3ba into nrwl:master Jan 20, 2023
FrozenPandaz pushed a commit that referenced this pull request Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack dev server executor not respecting server.type of 'https'
4 participants