Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): react monorepo account for bundler #14617

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

mandarini
Copy link
Member

closed #14614

Current Behavior

bundler is ignored in react-monorepo cases. It's hard-coded to be webpack.

Expected Behavior

Take into account bundler option when generating react-monorepo

Related Issue(s)

Fixes #14614

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 4:29PM (UTC)

@mandarini mandarini requested a review from jaysoo January 25, 2023 16:25
@mandarini mandarini self-assigned this Jan 25, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-nx-workspace doesn't configure vite
2 participants