fix(webpack): fix support for module federation plugin #14653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
issue/14629
branch
4 times, most recently
from
199d061
to
9ae06de
Compare
- Add context back to webpack config - Make composePlugins work with async plugins like withModuleFederation Fixes #146292
mandarini
approved these changes
Jan 27, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 27, 2023
(cherry picked from commit 795e4d6)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.contextback to webpack config (inwithNx)composePluginswork with async plugins likewithModuleFederation, and addcomposePluginsSyncfor a sync versionwithModuleFederationso it chains the context towithReactpluginCurrent Behavior
Module federation is not working out of the box.
Expected Behavior
Module federation works out of the box.
Related Issue(s)
Fixes #14692