fix(webpack): config migrations should account for different configurations

[jaysoo]

This PR fixes an issue where different configurations (e.g. deveopment and production) can mess up migrations between @nrwl/webpack and @nrwl/react.

For example, @nrwl/react migrates a custom webpack.config.js correctly, but now @nrwl/webpack looks at the options, which is like this:

build: {
  ...
  "options": {
     "isolatedConfig": true,
     "main": "myapp/main.tsx",
    "webpackConfig": "myapp/webpack.alreadymigrated.config.js"
  },
  "configurations": {
     "production": {
        "webpackConfig": "myapp/webpack.alreadymigrated.prod.config.js"
      }
  }

And for production configuration, the new isolatedConfig flag is not set, and there is a custom webpackConfig so @nrwl/webpack performs a migration that isn't needed.

The fix is make sure we keep track of the default options, and if the default options need to be migrated, then other configurations may also need to be migrated. If the default options do not need a migration, then skip the rest of the configurations.

Notes

• The check for main.tsx needs to be on default options, because each configuration will likely not provide a different main option.
• Updating project configuration should update the options field for default options, or <configurationName> for things like development and production.
• Isolated each test case to set up required projects, rather than having everything shared in beforeEach.
• Two new test cases were added to check the configuration case (one in webpack, one in React).

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nx-dev	⬜️ Ignored (Inspect)			Jan 27, 2023 at 8:34PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e47e520. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=6422d3da9d54cad6b93297aa1296c3c1d86698b3 --head=e47e52007503d48030f44be517a20dbad16950a2 --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=6422d3da9d54cad6b93297aa1296c3c1d86698b3 --head=e47e52007503d48030f44be517a20dbad16950a2 --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=6422d3da9d54cad6b93297aa1296c3c1d86698b3 --head=e47e52007503d48030f44be517a20dbad16950a2 --parallel=3
• nx affected --target=build --base=6422d3da9d54cad6b93297aa1296c3c1d86698b3 --head=e47e52007503d48030f44be517a20dbad16950a2 --parallel=3
• nx-cloud record -- nx format:check --base=6422d3da9d54cad6b93297aa1296c3c1d86698b3 --head=e47e52007503d48030f44be517a20dbad16950a2
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.