fix(bundling): combine user-defined external esbuild options with ours #14755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
fix/esbuild-respect-custom-external-config
branch
2 times, most recently
from
99cd30f
to
4f6b16f
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c0834c7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/esbuild-respect-custom-external-config
branch
from
4f6b16f
to
d7d5c25
Compare
jaysoo
force-pushed
the
fix/esbuild-respect-custom-external-config
branch
from
d7d5c25
to
c0834c7
Compare
jaysoo
commented
Feb 1, 2023
| @@ -0,0 +1,5 @@ | |||
| { | |||
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users define their own 'esbuildOptions.external`, Nx should combine that with its own.
Notes
bundle: falsethenexternalshould be set toundefined, otherwise esbuild will error.