Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): remove root config files #14780

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Feb 2, 2023

Remove the root config directory and files, since they do not really offer much.

This SHOULD go into a RELEASE

  • Automatic migration is not possible for all use cases
  • Write migrator that ONLY adds @storybook/addon-essentials to all project-level storybook instances and removes it from root storybook .storybook/main.js file
  • GUIDE explaining how this is not a breaking change - old config still works - it's just new generator does not generate root config
  • Explain why users should move to project-based config and abandon root config, but they can keep the root if they want to
  • Explain how they can create a root if they want to
  • If root config is empty, migrator removes it and removes its imports from everywhere
  • If root config is not empty (after removing @storybook/addon-essentials, then leave it as it is)

TODO:

  • Remove rootMain.webpack config stuff too
  • Write guide and explanation
  • Create migration object into the migration array

TESTING:

Tested it locally and it works. I have a workspace with angular, react, nextjs, web-component apps and libs, with storybook, migrated to new setup and all works as before.

@mandarini mandarini self-assigned this Feb 2, 2023
@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 5:28PM (UTC)

@mandarini mandarini force-pushed the feat/remove-root-storybook-config branch 16 times, most recently from 12f9531 to 5f4a03c Compare February 7, 2023 11:10
@mandarini mandarini marked this pull request as ready for review February 7, 2023 11:10
@mandarini mandarini force-pushed the feat/remove-root-storybook-config branch from 5f4a03c to dd99247 Compare February 7, 2023 11:42
@mandarini mandarini enabled auto-merge (squash) February 7, 2023 15:47
@mandarini mandarini merged commit 61cadc3 into nrwl:master Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants