-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): remove root config files #14780
Merged
mandarini
merged 1 commit into
nrwl:master
from
mandarini:feat/remove-root-storybook-config
Feb 7, 2023
Merged
feat(storybook): remove root config files #14780
mandarini
merged 1 commit into
nrwl:master
from
mandarini:feat/remove-root-storybook-config
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
12f9531
to
5f4a03c
Compare
5f4a03c
to
dd99247
Compare
dd99247
to
4d83ad6
Compare
4d83ad6
to
e5f6ccf
Compare
e5f6ccf
to
f41d01c
Compare
f41d01c
to
709eaf7
Compare
709eaf7
to
1e2e443
Compare
1e2e443
to
2c3bc22
Compare
isaacplmann
approved these changes
Feb 7, 2023
2c3bc22
to
f7aa219
Compare
leosvelperez
approved these changes
Feb 7, 2023
jaysoo
approved these changes
Feb 7, 2023
FrozenPandaz
approved these changes
Feb 7, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the root config directory and files, since they do not really offer much.
This SHOULD go into a RELEASE
@storybook/addon-essentials
to all project-level storybook instances and removes it from root storybook.storybook/main.js
file@storybook/addon-essentials
, then leave it as it is)TODO:
TESTING:
Tested it locally and it works. I have a workspace with angular, react, nextjs, web-component apps and libs, with storybook, migrated to new setup and all works as before.