Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): tidy up supported options #14793

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 3, 2023

Current Behavior

Some options did not have a note about their Support range.

webpack-server builder should also have had a runtime check for bundleDependencies

Expected Behavior

Added the relevant notes to generator and executor options
Add runtime check for webpack-server builder

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 3:27PM (UTC)

@Coly010 Coly010 self-assigned this Feb 3, 2023
@Coly010 Coly010 merged commit 829df2b into nrwl:master Feb 8, 2023
@Coly010 Coly010 deleted the angular/docs-for-supported-options branch February 8, 2023 15:05
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants