Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): resolve dev & preview server promises on process exit #14812

Merged

Conversation

dmitry-stepanenko
Copy link
Contributor

Current Behavior

Dev and preview server are creating promises that never exit. Because of this each time these servers executed and exited there's a new zombie process left.

To reproduce:

  1. npx create-nx-workspace zombie-processes --preset=react-monorepo --appName=my-app --bundler=vite
  2. In 2nd terminal run ps aux | grep zombie-demo
  3. Back in 1st terminal nx run my-app:serve and then exit after it's established
  4. Run command from step 2 again and see increased amount of processes. Repeat step 3 to see an extra process appears each time

Expected Behavior

There should be no zombie processes

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 6, 2023 at 9:27AM (UTC)

@dmitry-stepanenko
Copy link
Contributor Author

cc @jaysoo @mandarini

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit b35187c into nrwl:master Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants