Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): pass the correct config to user when isolatedConfig=false #14912

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 10, 2023

Current Behavior

If user sets isolatedConfig: false (skipped migration or manually changed it), then the legacy config is not passed to the user.

Expected Behavior

The legacy config should be passed to the user's config function so they can enhance it.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:29PM (UTC)

@jaysoo jaysoo merged commit 7185c5f into nrwl:master Feb 10, 2023
@jaysoo jaysoo deleted the fix/webpack-user-config branch February 10, 2023 14:08
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants