Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): explicitly export type instead of a value from d.ts files #15029

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

dmitry-stepanenko
Copy link
Contributor

Current Behavior

When types are exported from d.ts files, typescript actually creates an export from corresponding module, which is not valid in case of types
image

Expected Behavior

Should have all exported types explicitly marked as type in order to not have require statements for them in compiled index.js of a package

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 15, 2023 at 6:21PM (UTC)

@dmitry-stepanenko dmitry-stepanenko changed the title fix(vite): explicitly export type instead of value from d.ts files fix(vite): explicitly export type instead of a value from d.ts files Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants