Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): support custom import paths based on tsconfig when building node apps #15154

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 21, 2023

This PR fixes an issue when a library has a custom import path that isn't just @org/libname.

For example, nx g @nrwl/node:lib mylib --importPath=@something-custom/my-lib.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 21, 2023 at 4:21PM (UTC)

@jaysoo jaysoo force-pushed the fix/esbuild-custom-import-paths branch from 492c9b1 to 31b09fd Compare February 21, 2023 16:21
@jaysoo jaysoo merged commit a45d52e into nrwl:master Feb 21, 2023
@jaysoo jaysoo deleted the fix/esbuild-custom-import-paths branch February 21, 2023 17:56
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants