Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): generate correct build options for rollup bundler; by defaul… #15184

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Feb 23, 2023

…t and with swc compiler

Current Behavior

Generate a library with --bundle=rollup fails nx build lib-name due to misconfigured build#options.
Generate a library with --bundle=rollup --compiler=swc does not use swc plugin from rollup:rollup

Expected Behavior

Generate the correct build options and use swc plugin if --compiler=swc is passed in when generating a library with --bundle=rollup

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 2:58AM (UTC)

@jaysoo jaysoo merged commit 2f4f287 into nrwl:master Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants