Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add option to enable/disable cors for file-server #15220

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 24, 2023

Current Behavior

Cors is always enabled by default on file-server with no option of turning it off

Expected Behavior

We should allow users to optionally disable cors

Related Issue(s)

Fixes #14454

@Coly010 Coly010 self-assigned this Feb 24, 2023
@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 11:00AM (UTC)

@Coly010 Coly010 merged commit f2faf22 into nrwl:master Feb 24, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling or configuration of CORS in @nrwl/angular:file-server executor options
2 participants