Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): default Node scriptType to CommonJS since it has the widest compatibility #15483

Merged
merged 1 commit into from Mar 6, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 6, 2023

This PR fixes a regression with Node, where scriptType is set to module which cannot be used unless explicitly run as ESM (e.g. with .mjs file).

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #15125

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 6, 2023 at 9:22PM (UTC)

@jaysoo jaysoo force-pushed the issues/15125 branch 3 times, most recently from c1e4ac2 to cdefd77 Compare March 6, 2023 20:37
@jaysoo jaysoo enabled auto-merge (squash) March 6, 2023 21:22
@jaysoo jaysoo merged commit d7cd153 into nrwl:master Mar 6, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2023
nartc pushed a commit to nartc/nx that referenced this pull request Mar 9, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Federation React + SSR Broken in 15.7.2 .Works on 15.4.4 (Cannot use 'import.meta' outside a module)
2 participants