Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): ci workflow generator use correct default branch #15487

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix(misc): ci workflow generator use correct default branch #15487

merged 2 commits into from
Mar 7, 2023

Conversation

cbl980226
Copy link
Contributor

closed #14540

Current Behavior

repo: https://github.com/cbl980226/nx-github-workflow-error/actions/runs/4324108799/jobs/7548525612

Expected Behavior

Related Issue(s)

Fixes #14540

@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 2:38PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Mar 7, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4d8d3bf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unit test snapshot

I have fixed the broken snapshot

@meeroslav meeroslav self-assigned this Mar 7, 2023
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@meeroslav
Copy link
Contributor

Thank you for the PR @cbl980226!

FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2023
Co-authored-by: Miroslav Jonaš <meeroslav@users.noreply.github.com>
(cherry picked from commit fc75166)
nartc pushed a commit to nartc/nx that referenced this pull request Mar 9, 2023
Co-authored-by: Miroslav Jonaš <meeroslav@users.noreply.github.com>
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci-workflow generator use specified main branch name,maybe better.
2 participants