fix(node): add default build configuration #15542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bb9e445. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/node-default-build-config
branch
2 times, most recently
from
230b1ab
to
3cba27b
Compare
ndcunningham
approved these changes
Mar 8, 2023
jaysoo
force-pushed
the
fix/node-default-build-config
branch
from
3cba27b
to
09122d8
Compare
nartc
approved these changes
Mar 8, 2023
jaysoo
force-pushed
the
fix/node-default-build-config
branch
from
09122d8
to
bb9e445
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 8, 2023
(cherry picked from commit a69f8ab)
nartc
pushed a commit
to nartc/nx
that referenced
this pull request
Mar 9, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
developmentconfig for Node build and serve targets, and fixes an issue whereesbuildOptionsin prod is being overridden to generate.cjsinstead of.jsfiles.Current Behavior
npx nx build --prodgenerates.cjsfilesExpected Behavior
npx nx build --prodgenerates.jsfiles, and is the same asnpx nx buildRelated Issue(s)
Fixes #