Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): resolve browserTarget options correctly in webpack-dev-server #15638

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 13, 2023

Current Behavior

The @nrwl/angular:webpack-dev-server executor is not correctly resolving the browserTarget options.

Expected Behavior

The @nrwl/angular:webpack-dev-server executor should resolve the browserTarget options correctly.

Related Issue(s)

Fixes #15561

@leosvelperez leosvelperez self-assigned this Mar 13, 2023
@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 13, 2023 at 4:28PM (UTC)

@leosvelperez leosvelperez changed the title fix(angular): resolve build target options correctly in webpack-dev-server fix(angular): resolve browserTarget options correctly in webpack-dev-server Mar 13, 2023
@leosvelperez leosvelperez marked this pull request as ready for review March 13, 2023 16:53
@leosvelperez leosvelperez merged commit db682bf into nrwl:master Mar 14, 2023
@leosvelperez leosvelperez deleted the angular/dev-server-build-target-options branch March 14, 2023 09:45
FrozenPandaz pushed a commit that referenced this pull request Mar 15, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use TypeScript Paths in @nrwl/angular:module-federation-dev-server
2 participants