fix(nextjs): refactor how webpack config is loaded with nextjs

[ndcunningham]

Currently, there is a breaking change that exists after you upgrade your next dependency to next:13.2.x

This happened because we would pass the webpack configuration to the nextJs's build function which is no longer supported

What does the mean for new / existing workspaces

• No changes are required

TODO

• Ensure imported shared libs compiles without errors
• Add e2e tests for nextjs workspaces
• Rename withNxnew function
• Remove webpack config from build.impl

Fixes: #15214, #13194

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nx-dev	⬜️ Ignored (Inspect)	Visit Preview		Mar 15, 2023 at 9:34PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9bd1d3c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=8e838b5aac1cbbb9376545a3b7e14c0190dda07f --head=9bd1d3cdc6a5c99587176fa693d4fa9b47d4532e --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=test --base=8e838b5aac1cbbb9376545a3b7e14c0190dda07f --head=9bd1d3cdc6a5c99587176fa693d4fa9b47d4532e --parallel=1
• nx affected --target=lint --base=8e838b5aac1cbbb9376545a3b7e14c0190dda07f --head=9bd1d3cdc6a5c99587176fa693d4fa9b47d4532e --parallel=3
• nx affected --target=build --base=8e838b5aac1cbbb9376545a3b7e14c0190dda07f --head=9bd1d3cdc6a5c99587176fa693d4fa9b47d4532e --parallel=3
• nx-cloud record -- nx format:check --base=8e838b5aac1cbbb9376545a3b7e14c0190dda07f --head=9bd1d3cdc6a5c99587176fa693d4fa9b47d4532e
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[mandarini]

Left a comment, then deleted it, because i was testing an issue that is not addressed, sorry!

[skaneprime]

Dunno should it be here but when building nextjs app it can't defy path correctly (ig it is next issue But not sure)

 info  - Checking validity of types ..Failed to compile.

../../../dist/apps/web/site/.next/types/app/layout.ts:2:24
Type error: Cannot find module '../../../../../../app/layout' or its corresponding type declarations.

  1 | // File: W:\vault\apps\web\site\app\layout.tsx
> 2 | import * as entry from '../../../../../../app/layout'
    |                        ^
  3 | import type { ResolvingMetadata } from 'next/dist/lib/metadata/types/metadata-interface'
  4 | 
  5 | type TEntry = typeof entry

 ——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Ran target build for project web-site (10s)

    ×    1/1 failed
    √    0/1 succeeded [0 read from cache]

// File: W:\vault\apps\web\site\app\layout.tsx
import * as entry from '../../../../../../app/layout' 
// path must be ../../../apps/subdir/project-name/app/layout 
// aka this ../../../apps/web/site/app/layout

import type { ResolvingMetadata } from 'next/dist/lib/metadata/types/metadata-interface'

type TEntry = typeof entry

// Check that the entry is a valid entry
...

next.config.js

  typescript: {
    ignoreBuildErrors: true // will solve the issue but this is workaround. 
  },

[ianldgs]

@skaneprime that's a known issue: #14558
And yes, it's on nextjs side, I'm planning to make a PR to fix it:
ianldgs/next.js@60f70d5

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.