Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): throw error for invalid project name in withModuleFederation helper #15694

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 15, 2023

Current Behavior

If an invalid project name is set in the module federation config, an empty set of dependencies is collected and no error is thrown.

Expected Behavior

If an invalid project name is set in the module federation config, an error should be thrown providing feedback for the dev to address the issue.

Related Issue(s)

Fixes #15686

@leosvelperez leosvelperez self-assigned this Mar 15, 2023
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 15, 2023 at 11:55AM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review March 15, 2023 12:35
@leosvelperez leosvelperez merged commit 76ec6f9 into nrwl:master Mar 15, 2023
@leosvelperez leosvelperez deleted the angular/mf-check-project-name branch March 15, 2023 14:14
FrozenPandaz pushed a commit that referenced this pull request Mar 15, 2023
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Mar 16, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw error on build if 'name' in Module Federation config does not match a project name
2 participants