Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): prevent inserting a leading comma in NgModule properties #15933

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 28, 2023

Current Behavior

The utility used by various generators to insert a property value in an NgModule inserts a leading comma when the existing property value is an empty array.

Expected Behavior

The utility used by various generators to insert a property value in an NgModule should not insert a leading comma when the existing property value is an empty array.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 28, 2023
@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 28, 2023 at 4:53PM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review March 28, 2023 17:27
@leosvelperez leosvelperez enabled auto-merge (squash) March 28, 2023 17:27
@FrozenPandaz FrozenPandaz merged commit 091978b into nrwl:master Mar 28, 2023
3 checks passed
@leosvelperez leosvelperez deleted the angular/fix-ngmodule-prop-insert branch March 28, 2023 19:09
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants