Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): allow skiping formatFiles in component generator when called from another generator #15953

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 29, 2023

Current Behavior

When creating a library with a standalone component, the component generator is invoked and this generator calls formatFiles. There's no way to skip that inner call which causes multiple formatFiles to run.

Expected Behavior

When creating a library with a standalone component, formatFiles shouldn't run multiple times.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 29, 2023
@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 9:50AM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review March 29, 2023 09:49
@leosvelperez leosvelperez merged commit 75f6b98 into nrwl:master Mar 29, 2023
3 checks passed
@leosvelperez leosvelperez deleted the angular/component-skip-format branch March 29, 2023 10:17
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants