Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): configure terser plugin with non-deprecated options for… #15968

Conversation

yharaskrik
Copy link
Contributor

… tsc

Current Behavior

the webpack plugin is currently using what looks like deprecated options for the terser webpack plugin (they have moved to format from output now).

Expected Behavior

This moves the options to the right spot in the terser webpack plugin config and adds the extractComments flag set to false as it seems based on existing functionality the intention was to not include comments by default so I added the other flag as that is what the documentation has for that case: https://webpack.js.org/plugins/terser-webpack-plugin/#remove-comments

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 30, 2023 at 0:05AM (UTC)

@jaysoo jaysoo merged commit d47d3f1 into nrwl:master Mar 30, 2023
3 checks passed
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants