Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): adding "none" style option to next component generator #15990

Merged
merged 2 commits into from Mar 31, 2023

Conversation

ashley-hunter
Copy link
Contributor

@ashley-hunter ashley-hunter commented Mar 30, 2023

The React component generator has the option to choose "none" as a style option, particularly useful when using Tailwind. The Next.js component generator omits this option, even though the underlying React component generator allows it. This updates the generator schema to expose "none" as an option.

Current Behavior

There is a "none" style option for the React component generator, but not the Next.js component generator.

Expected Behavior

"None" should be supported in the Next.js generator.

Related Issue(s)

Fixes #

The React component generator has the option to choose "none" as a style option, particularly useful
when using Tailwind. The Next.js component generator omits this option, even though the underlying
React component generator allows it. This updates the generator schema to expose "none" as an
option.
@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 9:39PM (UTC)

@xiongemi xiongemi merged commit 5211382 into nrwl:master Mar 31, 2023
15 checks passed
@ashley-hunter ashley-hunter deleted the next-none-style branch March 31, 2023 20:51
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants