Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): add missing @babel/core dependency to @nrwl/webpack #16023

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 31, 2023

Since babel-loader has a peer dependency on @babel/core, we need to make sure the version installed is correct. It was missing for @nrwl/webpack which leads to problems if the workspace has its own version installed.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #15985

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 31, 2023 at 7:59PM (UTC)

@jaysoo jaysoo enabled auto-merge (squash) March 31, 2023 20:36
@jaysoo jaysoo merged commit bfea455 into nrwl:master Mar 31, 2023
@jaysoo jaysoo deleted the fix/webpack-missing-babel-core-dep branch March 31, 2023 21:08
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build web apps after updating to Nx >= 15.5.3
3 participants