Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): support ESM js imports in ast utils #16049

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

AST' getRelativeImportPath breaks when barrel imports use ESM .js imports since file load fails.

Expected Behavior

AST' getRelativeImportPath should remap aliased ESM .js imports into appropriate .ts/.tsx imports whenever possible

Related Issue(s)

Fixes #15996

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Apr 3, 2023
@meeroslav meeroslav self-assigned this Apr 3, 2023
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 3, 2023 8:52am

@FrozenPandaz FrozenPandaz merged commit 89d0b8b into nrwl:master Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
@meeroslav meeroslav deleted the fix-linter-js-ast-utils branch April 27, 2023 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/nx/enforce-module-boundaries doesn't work with ESM .js-style imports of TS files
2 participants