-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): consider app-routing.module.ts when setting up module federation host routes #16285
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I think this is a reasonable thing to support. There's only one issue with the changes. Once addressed, it should be good to go 🚀
packages/angular/src/generators/setup-mf/lib/update-host-app-routes.ts
Outdated
Show resolved
Hide resolved
@aliataf there was an issue with CircleCI not kicking the pipeline. I had to rebase the PR to unblock it. |
…ederation host routes (nrwl#16285) Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Getting
Cannot read properties of null (reading 'length')
when running:npx nx g @nrwl/angular:setup-mf appName --mfType=host
Expected Behavior
It should generate the module federation config regardless of whether you use
app.routes.ts
orapp-routing.module.ts
Related Issue(s)
Fixes #14075