Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): consider app-routing.module.ts when setting up module federation host routes #16285

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

aliataf
Copy link
Contributor

@aliataf aliataf commented Apr 13, 2023

Current Behavior

Getting Cannot read properties of null (reading 'length') when running:
npx nx g @nrwl/angular:setup-mf appName --mfType=host

Expected Behavior

It should generate the module federation config regardless of whether you use app.routes.ts or app-routing.module.ts

Related Issue(s)

Fixes #14075

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 14, 2023 2:08pm

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I think this is a reasonable thing to support. There's only one issue with the changes. Once addressed, it should be good to go 🚀

@leosvelperez leosvelperez self-assigned this Apr 13, 2023
@leosvelperez leosvelperez changed the title fix(generators): check for other routing path fix(angular): consider app-routing.module.ts when setting up module federation host routes Apr 13, 2023
@leosvelperez
Copy link
Member

@aliataf there was an issue with CircleCI not kicking the pipeline. I had to rebase the PR to unblock it.

@leosvelperez leosvelperez merged commit 3e45445 into nrwl:master Apr 14, 2023
peppoasap pushed a commit to peppoasap/nx that referenced this pull request Apr 18, 2023
…ederation host routes (nrwl#16285)

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of null (reading 'length') while generating @nrwl/angular:setup-mf
2 participants