Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): do not generate test for appDir page.tsx #16509

Merged

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Apr 24, 2023

Current Behavior

when using the new appDir apps are generated with a spec file pointing to the old pages dir

Expected Behavior

tests are not generated for appDir since page.tsx is an async server side component.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 4:58pm

@barbados-clemens barbados-clemens self-assigned this Apr 24, 2023
@barbados-clemens barbados-clemens added scope: nextjs Issues related to NextJS support for Nx scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx labels Apr 24, 2023
@barbados-clemens barbados-clemens changed the title fix(nextjs): generate working spec file for --appDir fix(nextjs): do not generate test for default component with appDir Apr 24, 2023
@ndcunningham ndcunningham self-requested a review April 24, 2023 17:22
@barbados-clemens barbados-clemens changed the title fix(nextjs): do not generate test for default component with appDir fix(nextjs): do not generate test for appDir page.tsx Apr 24, 2023
@barbados-clemens barbados-clemens merged commit 808b4d1 into nrwl:master Apr 24, 2023
6 checks passed
@barbados-clemens barbados-clemens deleted the fix/next-app-dir-specs branch April 24, 2023 18:18
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants