-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): do not generate test for appDir page.tsx #16509
Merged
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/next-app-dir-specs
Apr 24, 2023
Merged
fix(nextjs): do not generate test for appDir page.tsx #16509
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/next-app-dir-specs
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbados-clemens
requested review from
ndcunningham,
jaysoo and
xiongemi
as code owners
April 24, 2023 15:55
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
added
scope: nextjs
Issues related to NextJS support for Nx
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
labels
Apr 24, 2023
ndcunningham
requested changes
Apr 24, 2023
packages/next/src/generators/application/files/app/page.tsx__tmpl__
Outdated
Show resolved
Hide resolved
barbados-clemens
force-pushed
the
fix/next-app-dir-specs
branch
from
April 24, 2023 16:49
17147a1
to
4f0642c
Compare
barbados-clemens
changed the title
fix(nextjs): generate working spec file for --appDir
fix(nextjs): do not generate test for default component with appDir
Apr 24, 2023
ndcunningham
approved these changes
Apr 24, 2023
barbados-clemens
changed the title
fix(nextjs): do not generate test for default component with appDir
fix(nextjs): do not generate test for appDir page.tsx
Apr 24, 2023
This was referenced Apr 28, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
scope: nextjs
Issues related to NextJS support for Nx
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
when using the new appDir apps are generated with a spec file pointing to the old pages dir
Expected Behavior
tests are not generated for appDir since page.tsx is an async server side component.
Related Issue(s)
Fixes #