Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): add @swc/core when adding storybook-addon-swc package for Next.js storybook config #16553

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 25, 2023

We missed a previous install of @swc/core when generating Next.js storybook configuration for Storybook v6.

Note, SB v7 has a different @storybook/nextjs addon that doesn't need this fix.

Current Behavior

Generating stories for Next.js app in 15.9 results in an error due to @swc/core not being installed.

Expected Behavior

Generating stories for Next.js app in 15.9 works.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 25, 2023 7:49pm

@jaysoo jaysoo merged commit 33303fe into nrwl:15.9.x Apr 26, 2023
@jaysoo jaysoo deleted the fix/15-9-3-nextjs-sb branch April 26, 2023 12:43
@github-actions
Copy link

github-actions bot commented May 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants