Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): update import paths relative to app config file location in migration extracting the config #16863

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 8, 2023

Current Behavior

The migration extracting the standalone config from the bootstrapApplication call into a separate file doesn't rewrite the relative import paths considering the new file location.

Expected Behavior

The migration extracting the standalone config from the bootstrapApplication call into a separate file should rewrite the relative import paths as needed based on the new file location.

Related Issue(s)

Fixes #16849

@leosvelperez leosvelperez self-assigned this May 8, 2023
@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) May 8, 2023 1:36pm

@leosvelperez leosvelperez marked this pull request as ready for review May 8, 2023 13:55
@leosvelperez leosvelperez requested a review from Coly010 as a code owner May 8, 2023 13:55
@leosvelperez leosvelperez merged commit 7d42d88 into nrwl:master May 9, 2023
3 checks passed
@leosvelperez leosvelperez deleted the angular/fix-migration-app-config-import-paths branch May 9, 2023 08:30
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx upgrade from v15.x to v16.1.1 produces wrong app.routes.ts paths for Angular apps
2 participants