Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add react-specific eslint configuration #1727

Merged
merged 1 commit into from Aug 15, 2019

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 15, 2019

Changes

  • Generating React apps/libs will create React-specific eslint config, and install necessary package deps.
  • Extend addLintFiles in@nrwl/workspace to allow custom local config and package deps to be specified.
  • Move React-specific eslint config into the @nrwl/react package.

Output

Running nx lint [project] for React apps and libs will now check for React-specific rules--such as proper hooks usages.

@jaysoo jaysoo merged commit 13e7b69 into nrwl:master Aug 15, 2019
@jaysoo jaysoo deleted the react-eslint branch August 15, 2019 17:01
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant