Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): Ensure runTimeArgs are not ignored #17527

Merged
merged 1 commit into from Jun 12, 2023

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jun 9, 2023

closes: #17513

@ndcunningham ndcunningham requested a review from a team as a code owner June 9, 2023 16:49
@ndcunningham ndcunningham requested a review from jaysoo June 9, 2023 16:49
@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 4:55pm

@jaysoo jaysoo enabled auto-merge (squash) June 12, 2023 14:01
@jaysoo jaysoo merged commit 478fb8b into nrwl:master Jun 12, 2023
15 checks passed
@ndcunningham ndcunningham deleted the fix/js-node-run-time-args branch June 12, 2023 14:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
@ndcunningham ndcunningham self-assigned this Jul 25, 2023
@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx/js node executor does not handle options args and runtimeArgs properly
2 participants