Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): Correct schema for export executor #18085

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

makirby
Copy link
Contributor

@makirby makirby commented Jul 12, 2023

Current Behavior

Cannot provide the dumpSourcemap or dumpAssetmap args to expo export executor

Expected Behavior

You can provide the dumpSourcemap and dumpAssetmap args to expo executor

Expo CLI reference: https://github.com/expo/expo-cli/blob/9250eefb151ff17a6873093c7ff33b20597d03d6/packages/expo-cli/src/commands/export/exportAppAsync.ts#L57C1-L57C1

Related Issue(s)

Fixes #

@makirby makirby requested a review from a team as a code owner July 12, 2023 12:02
@makirby makirby requested a review from mandarini July 12, 2023 12:02
@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 0:53am

@mandarini mandarini self-assigned this Jul 12, 2023
@mandarini
Copy link
Member

@makirby thanks for the PR. Can you please run pnpm documentation and commit again?

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pnpm documentation for the docs to be generated properly

@mandarini mandarini requested a review from a team as a code owner August 1, 2023 12:50
@mandarini mandarini merged commit 510e03d into nrwl:master Aug 2, 2023
15 checks passed
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants