fix(core): provide taskGraph for every task calculation #18410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cammisuli
force-pushed
the
pass_taskgraph_as_argument
branch
from
34ecc93
to
0f88943
Compare
Cammisuli
force-pushed
the
pass_taskgraph_as_argument
branch
from
0f88943
to
f0685a2
Compare
Cammisuli
force-pushed
the
pass_taskgraph_as_argument
branch
from
f0685a2
to
2c25244
Compare
Cammisuli
force-pushed
the
pass_taskgraph_as_argument
branch
from
2c25244
to
711b8d7
Compare
Cammisuli
force-pushed
the
pass_taskgraph_as_argument
branch
from
711b8d7
to
4754805
Compare
FrozenPandaz
requested changes
Aug 1, 2023
Comment on lines
62
to
63
| hashTask(task: Task, taskGraph?: TaskGraph): Promise<Hash>; | ||
| hashTasks(tasks: Task[], taskGraph?: TaskGraph): Promise<Hash[]>; |
There was a problem hiding this comment.
Why is it optional here?
| @@ -85,7 +84,7 @@ async function createTasks( | |||
| const tasks = Object.values(taskGraph.tasks); | |||
|
|
|||
| await Promise.all( | |||
| tasks.map((t) => hashTask(hasher, projectGraph, {} as any, t)) | |||
There was a problem hiding this comment.
What was this object being passed for?
There was a problem hiding this comment.
it was used for custom hashers 🤷🏼
Cammisuli
force-pushed
the
pass_taskgraph_as_argument
branch
from
8547043
to
a1cb63d
Compare
Cammisuli
force-pushed
the
pass_taskgraph_as_argument
branch
from
a1cb63d
to
f8f24fa
Compare
FrozenPandaz
approved these changes
Aug 1, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using the daemon - the taskGraph was not updated while recalculating the inputs for the task hashes.
Expected Behavior
The taskGraph is now passed and used for every call to the
hashTaskfunction, so the latest version of the taskGraph is used.Related Issue(s)
Fixes #