fix(core): esbuild generateLockfile according to docs

[dearlordylord]

Current Behavior

esbuild:esbuild executor will generate package.json

Expected Behavior

esbuild:esbuild executor will generate package.json together with a lockfile according to documentation https://nx.dev/packages/esbuild/executors/esbuild#generatepackagejson

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2023 1:23pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7a9b17f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=e2e --base=48deaec60f3670c385df244cd84fdaf35b878e37 --head=7a9b17f360e2323cfcf180a094e63a2f68484356 --parallel=1
• linux nx affected --target=build --base=48deaec60f3670c385df244cd84fdaf35b878e37 --head=7a9b17f360e2323cfcf180a094e63a2f68484356 --parallel=3
• linux nx affected --target=lint --base=48deaec60f3670c385df244cd84fdaf35b878e37 --head=7a9b17f360e2323cfcf180a094e63a2f68484356 --parallel=3
• linux nx affected --target=test --base=48deaec60f3670c385df244cd84fdaf35b878e37 --head=7a9b17f360e2323cfcf180a094e63a2f68484356 --parallel=1
• nx-cloud record -- nx format:check --base=48deaec60f3670c385df244cd84fdaf35b878e37 --head=7a9b17f360e2323cfcf180a094e63a2f68484356
• linux nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[mandarini]

Thank you for the contribution @Firfi !

[mandarini]

Can we also add a e2e check? I'll show you where exactly!

Maybe add a line to check below here:
https://github.com/nrwl/nx/blob/master/e2e/esbuild/src/esbuild.test.ts#L54

like:

checkFilesExist(`dist/libs/${myPkg}/package-lock.json`);

[mandarini]

Thank you @Firfi ! I'll take over from here, don't worry!

[dearlordylord]

@mandarini thank you for this direction. I've added a test. There's a peculiarity I found though. Depending on the package manager used, the code would generate an appropriate lockfile. So, for my project, it generates package-lock.json, but in e2e, it generates pnpm-lock. I tried to switch to Yarn, and it does start generating yarn.lock.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.