Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): do not set default host as localhost #18419

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

host defaults to localhost, overriding native behaviour.

Expected Behavior

host should not default to anything (if not set, leave undefined)

Related Issue(s)

Fixes #18376

@mandarini mandarini self-assigned this Aug 1, 2023
@mandarini mandarini requested review from a team as code owners August 1, 2023 12:39
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 0:42am

@mandarini mandarini merged commit 90e4e7e into nrwl:master Aug 1, 2023
15 checks passed
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
@mandarini mandarini deleted the fix/storybook-host-no-default branch August 22, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/storybook:storybook 16.5.3 overrides networkAddress with localhost.
3 participants