Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): plugin quality indicators #18426

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented Aug 1, 2023

Adds quality indicators to the plugin registry.
https://nx-dev-git-docs-plugin-registry-nrwl.vercel.app/extending-nx/registry

Screenshot 2023-08-02 at 2 38 07 PM

Now the PR also includes sorting buttons. It seemed like filters weren't necessary once the sorting was available.

This PR is functional as is, but more work is planned in future PRs:

  • Update the quality indicators in CI
  • Display README content for plugins in their own dedicated page

@isaacplmann isaacplmann requested review from a team as code owners August 1, 2023 19:26
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 2:25pm

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this not be committed? Could we have a github action generate this and trigger a vercel deploy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's possible.

The only problem with that is there are a lot of network calls that happen in the script. If something goes wrong on the network, then the live data will be wrong. Committing the results of the script at least gives us a chance to double check that we haven't lost the npm downloads for every package.

nx-dev/ui-common/src/lib/plugin-card.tsx Outdated Show resolved Hide resolved
nx-dev/ui-common/src/lib/plugin-card.tsx Outdated Show resolved Hide resolved
nx-dev/ui-common/src/lib/plugin-card.tsx Outdated Show resolved Hide resolved
scripts/documentation/plugin-quality-indicators.ts Outdated Show resolved Hide resolved
scripts/documentation/plugin-quality-indicators.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script that generates plugin quality indicators doesn't seem to be running automatically.

Additionally, the text on hover is not working anymore since entire card is a link:
Screenshot 2023-08-03 at 14 20 12

I would move the official pill on the header in the right corner on mobile view

@isaacplmann
Copy link
Collaborator Author

isaacplmann commented Aug 3, 2023

Text on hover is fixed and the Nx Team pill has always been in the right corner.

@isaacplmann
Copy link
Collaborator Author

@meeroslav I figured out what you meant about the Nx Team pill. I've fixed it so the pill stays in the right corner when it wraps to the next line.

@meeroslav meeroslav merged commit f1a90bf into master Aug 3, 2023
15 checks passed
@meeroslav meeroslav deleted the docs/plugin-registry branch August 3, 2023 15:15
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants