Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): update getComponentsInfo to filter null values #18431

Merged

Conversation

johnhwhite
Copy link
Contributor

Fixes the ignorePaths option in @nx/angular:stories generator.

closed #18430

Current Behavior

Running e.g. nx g @nx/angular:stories --name=example-app --ignorePaths='**/app.component.ts' --dry-run throws the error > NX Cannot read properties of undefined (reading 'moduleFolderPath')

Expected Behavior

No error and the generator works.

Related Issue(s)

Fixes #18430

Fixes the `ignorePaths` option in `@nx/angular:stories` generator.

closed nrwl#18430
@johnhwhite johnhwhite requested a review from a team as a code owner August 1, 2023 21:26
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 4:38am

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @johnhwhite !

@mandarini mandarini self-assigned this Aug 2, 2023
@mandarini mandarini enabled auto-merge (squash) August 2, 2023 07:44
@mandarini mandarini merged commit f02d230 into nrwl:master Aug 2, 2023
15 checks passed
@johnhwhite johnhwhite deleted the fix-angular-stories-ignorepath-option branch August 2, 2023 14:45
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/angular:stories generator ignorePaths option broken
3 participants